chore(write): address #168 nice-to-haves (code subset)#191
Merged
Conversation
…l-prefixed kaswrite wrap, mail-flag help - kaswrite.Call: prefix the module label onto the ErrUnexpectedReturnString wrap so a regression in e.g. mailforward.Client.Add no longer hides behind the canonical "kaswrite:" sentinel. - mail forwards add --target: help no longer claims to "replace the full target list" — that wording is true for update, not for add. - mail lists update --active: now a Y|N string flag, matching mail accounts update --active. Removes the slightly non-obvious --active=false form. - runWriteE: resolves credentials exactly once per invocation; the post-gate dispatch reuses the creds via the unexported buildAPIClientFromCreds helper instead of running config+env+flag resolution a second time inside BuildAPIClient. Refs #168.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Code subset of the #168 nice-to-have bundle from the post-#13 write-phase reviews. Items 5 (cronjob fixture echo-back comment) follows in a separate PR; items 6+7 stay accepted-as-noted.
kaswrite.Callprepends the modulelabelonto the wrappedErrUnexpectedReturnStringmessage so a regression in e.g.mailforward.Client.Adddoes not lose its module hint to the canonicalkaswrite:sentinel prefix. Sentinel identity unchanged.mail forwards add --targethelp no longer reads "replaces the full target list" — that wording is only accurate onupdate.mail lists update --activeis now aY|Nstring flag (matchesmail accounts update --active); removes the slightly non-obvious--active=falseform.runWriteEresolves credentials exactly once per invocation; the post-gate dispatch reuses them via the new unexportedbuildAPIClientFromCredshelper instead of running the config + env + flag resolution a second time insideBuildAPIClient.Refs #168.